[PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-08-14 Thread Santosh Y
From: Sujit Reddy Thumma Currently, sending Task Management (TM) command to the card might be broken in some scenarios as listed below: Problem: If there are more than 8 TM commands the implementation returns error to the caller. Fix: Wait for one of the slots to be emptied and send

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-03 Thread Sujit Reddy Thumma
On 7/3/2013 9:53 PM, Santosh Y wrote: On Wed, Jul 3, 2013 at 9:22 PM, Sujit Reddy Thumma wrote: On 7/2/2013 9:21 PM, Santosh Y wrote: On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host->host_lock, flags);

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-03 Thread Santosh Y
On Wed, Jul 3, 2013 at 9:22 PM, Sujit Reddy Thumma wrote: > On 7/2/2013 9:21 PM, Santosh Y wrote: >> >> On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma >> wrote: >>> >>> On 6/27/2013 4:49 PM, Santosh Y wrote: > > >> + spin_lock_irqsave(host->host_lock, flags); >>

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-03 Thread Sujit Reddy Thumma
On 7/2/2013 9:21 PM, Santosh Y wrote: On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host->host_lock, flags); task_req_descp = hba->utmrdl_base_addr; task_req_descp += free_slot; @@ -2353,38 +2387

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-02 Thread Santosh Y
On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma wrote: > On 6/27/2013 4:49 PM, Santosh Y wrote: >>> >>> >+ spin_lock_irqsave(host->host_lock, flags); >>> > task_req_descp = hba->utmrdl_base_addr; >>> > task_req_descp += free_slot; >>> > >>> >@@ -2353,38 +2387,39 @@ ufshcd

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-06-28 Thread Sujit Reddy Thumma
On 6/27/2013 4:49 PM, Santosh Y wrote: >+ spin_lock_irqsave(host->host_lock, flags); > task_req_descp = hba->utmrdl_base_addr; > task_req_descp += free_slot; > >@@ -2353,38 +2387,39 @@ ufshcd_issue_tm_cmd(struct ufs_hba *hba, > (struct utp_upiu_task_req *) ta

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-06-27 Thread Santosh Y
On Thu, Jun 13, 2013 at 8:00 PM, Sujit Reddy Thumma wrote: > Currently, sending Task Management (TM) command to the card might > be broken in some scenarios as listed below: > > - If there are more than 8 TM commands the implementation returns > error to the caller. > Fix: Wait for one of the slot

[PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-06-13 Thread Sujit Reddy Thumma
Currently, sending Task Management (TM) command to the card might be broken in some scenarios as listed below: - If there are more than 8 TM commands the implementation returns error to the caller. Fix: Wait for one of the slots to be emptied and send the command. - Sometimes it is necessary for