Re: [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd

On Wed, Apr 05, 2017 at 07:18:08PM +0200, Christoph Hellwig wrote: > ->retries is counting the number of times a command is resubmitted, and > be cleared on the first time we see the command. We currently don't do > that for non-PCIe command, which is easily fixed by moving the setup > to common

Re: [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd

Reviewed-by: Sagi Grimberg

[PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd

->retries is counting the number of times a command is resubmitted, and be cleared on the first time we see the command. We currently don't do that for non-PCIe command, which is easily fixed by moving the setup to common code. Signed-off-by: Christoph Hellwig ---

Re: [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd

On Wed, Apr 05, 2017 at 04:43:34PM +0200, Johannes Thumshirn wrote: > On Wed, Apr 05, 2017 at 04:18:52PM +0200, Christoph Hellwig wrote: > > This way we get the behavior right for the non-PCIe transports. > > Could you please share a bit of your minds inner workings for us mere mortals? It's

Re: [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd

On Wed, Apr 05, 2017 at 04:18:52PM +0200, Christoph Hellwig wrote: > This way we get the behavior right for the non-PCIe transports. Could you please share a bit of your minds inner workings for us mere mortals? Thanks, Johannes -- Johannes Thumshirn

[PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd

This way we get the behavior right for the non-PCIe transports. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/core.c | 5 + drivers/nvme/host/pci.c | 4 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/host/core.c