Re: [PATCH 1/7] scsi/bfa: use pcie_capability_xxx to simplify code

2013-09-05 Thread Yijing Wang
>> @@ -794,10 +793,8 @@ bfad_pci_init(struct pci_dev *pdev, struct bfad_s *bfad) >> break; >> } >> >> -pcie_cap_reg = pci_find_capability(pdev, PCI_CAP_ID_EXP); >> -if (mask != 0x && pcie_cap_reg) { >> -pcie_cap_reg

Re: [PATCH 1/7] scsi/bfa: use pcie_capability_xxx to simplify code

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 3, 2013 at 5:34 PM, Bjorn Helgaas wrote: > On Tue, Sep 03, 2013 at 03:35:09PM +0800, Yijing Wang wrote: >> Pcie_capability_xxx() interfaces were introudced to >> simplify code to access PCIe Cap config space. And >> because PCI core saves the PCIe Cap offset in >> set_pcie_port_type()

Re: [PATCH 1/7] scsi/bfa: use pcie_capability_xxx to simplify code

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 03, 2013 at 03:35:09PM +0800, Yijing Wang wrote: > Pcie_capability_xxx() interfaces were introudced to > simplify code to access PCIe Cap config space. And > because PCI core saves the PCIe Cap offset in > set_pcie_port_type() when device is enumerated. > So we can use pci_is_pcie() ins

[PATCH 1/7] scsi/bfa: use pcie_capability_xxx to simplify code

2013-09-03 Thread Yijing Wang
Pcie_capability_xxx() interfaces were introudced to simplify code to access PCIe Cap config space. And because PCI core saves the PCIe Cap offset in set_pcie_port_type() when device is enumerated. So we can use pci_is_pcie() instead. Signed-off-by: Yijing Wang Cc: Jiang Liu Cc: Anil Gurumurthy