The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL.
Hence remove the code that tests for this value.
Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
Cc: Don Brace <don.br...@pmcs.com>
---
drivers/scsi/hpsa.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 6bb4611..9d16a06 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3969,24 +3969,6 @@ static int hpsa_scsi_queue_command(struct Scsi_Host *sh,
struct scsi_cmnd *cmd)
c->Request.type_attr_dir =
TYPE_ATTR_DIR(TYPE_CMD, ATTR_SIMPLE, XFER_NONE);
break;
- case DMA_BIDIRECTIONAL:
- /* This can happen if a buggy application does a scsi passthru
- * and sets both inlen and outlen to non-zero. ( see
- * ../scsi/scsi_ioctl.c:scsi_ioctl_send_command() )
- */
-
- c->Request.type_attr_dir =
- TYPE_ATTR_DIR(TYPE_CMD, ATTR_SIMPLE, XFER_RSVD);
- /* This is technically wrong, and hpsa controllers should
- * reject it with CMD_INVALID, which is the most correct
- * response, but non-fibre backends appear to let it
- * slide by, and give the same results as if this field
- * were set correctly. Either way is acceptable for
- * our purposes here.
- */
-
- break;
-
default:
dev_err(&h->pdev->dev, "unknown data direction: %d\n",
cmd->sc_data_direction);
--
2.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
