Re: [PATCH 12/15] scsi: initial blk-mq support

2014-02-07 Thread Christoph Hellwig
> Is there extra scsi_mq_done() part that does IPI here even necessary > anymore..? > > I was under the assumption that blk_mq_end_io() is already taking care > of this..? blk_mq_end_io does it, but given that the SCSI-specific I/O completion path is non-trivial I'd rather run it on the indicated

Re: [PATCH 12/15] scsi: initial blk-mq support

2014-02-07 Thread Christoph Hellwig
On Fri, Feb 07, 2014 at 02:45:18AM -0600, Mike Christie wrote: > Yeah, it would be nice if like in Nick's patches, the driver could just > set the scsi_host_template->cmd_size then when the scsi_cmnd got to the > driver's queuecommand, the driver could just get its internal cmd struct > from the sc

Re: [PATCH 12/15] scsi: initial blk-mq support

2014-02-07 Thread Mike Christie
On 02/06/2014 04:11 PM, Nicholas A. Bellinger wrote: >> +struct request_queue *scsi_mq_alloc_queue(struct scsi_device *sdev) >> > +{ >> > + struct Scsi_Host *shost = sdev->host; >> > + struct blk_mq_hw_ctx *hctx; >> > + struct request_queue *q; >> > + struct request *rq; >> > + struct scsi_cmn

Re: [PATCH 12/15] scsi: initial blk-mq support

2014-02-06 Thread Nicholas A. Bellinger
On Wed, 2014-02-05 at 04:41 -0800, Christoph Hellwig wrote: > plain text document attachment > (0012-scsi-initial-blk-mq-support.patch) > Add support for using the blk-mq code to submit requests to SCSI > drivers. There is very little blk-mq specific code, but that's > partially because important

Re: [PATCH 12/15] scsi: initial blk-mq support

2014-02-06 Thread Christoph Hellwig
On Thu, Feb 06, 2014 at 10:38:17AM +0200, Sagi Grimberg wrote: > Both you and Nic offer a single HW queue per sdev. > I'm wandering if that should be the LLD's decision (if chooses to > use multiple queues)? > > Trying to understand how LLDs will fit in a way they exploit > multi-queue and actuall

Re: [PATCH 12/15] scsi: initial blk-mq support

2014-02-06 Thread Sagi Grimberg
On 2/5/2014 2:41 PM, Christoph Hellwig wrote: Add support for using the blk-mq code to submit requests to SCSI drivers. There is very little blk-mq specific code, but that's partially because important functionality like partial completions and request requeueing is still missing in blk-mq. I h

[PATCH 12/15] scsi: initial blk-mq support

2014-02-05 Thread Christoph Hellwig
Add support for using the blk-mq code to submit requests to SCSI drivers. There is very little blk-mq specific code, but that's partially because important functionality like partial completions and request requeueing is still missing in blk-mq. I hope to keep most of the additions for these in t