Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-14 Thread Pete Zaitcev
On Fri, 14 Dec 2007 12:04:54 -0500 (EST), Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > I have investigated all code paths which call ub_end_rq() in ub.c, > and confirmed that ub_end_rq() is always called with the queue lock > held. (sc->lock is registered as a queue lock.) Thanks for reminding me

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-14 Thread Kiyoshi Ueda
Hi Pete, On Thu, 13 Dec 2007 13:59:16 -0800, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > > > - end_that_request_first(rq, uptodate, rq->hard_nr_sectors); > > > > - end_that_request_last(rq, uptodate); > > > > + if (__blk_end_request(rq, error, blk_rq_bytes(rq))) > > > > +

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-13 Thread Pete Zaitcev
On Wed, 12 Dec 2007 15:38:15 -0500 (EST), Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > On Tue, 11 Dec 2007 15:48:03 -0800, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > > - end_that_request_first(rq, uptodate, rq->hard_nr_sectors); > > > - end_that_request_last(rq, uptodate); > > > + if (__blk_end_req

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-12 Thread Kiyoshi Ueda
Hi Pete, On Tue, 11 Dec 2007 15:48:03 -0800, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > if (scsi_status == 0) { > > - uptodate = 1; > > + error = 0; > > } else { > > - uptodate = 0; > > + error = -EIO; > > rq->errors = scsi_status; > >

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-11 Thread Pete Zaitcev
On Tue, 11 Dec 2007 17:46:47 -0500 (EST), Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > if (scsi_status == 0) { > - uptodate = 1; > + error = 0; > } else { > - uptodate = 0; > + error = -EIO; > rq->errors = scsi_status; >

[PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts ub to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Pete Zaitcev <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/ub.c | 10 +- 1 file