On Fri, 14 Dec 2007 12:04:54 -0500 (EST), Kiyoshi Ueda <[EMAIL PROTECTED]>
wrote:
> I have investigated all code paths which call ub_end_rq() in ub.c,
> and confirmed that ub_end_rq() is always called with the queue lock
> held. (sc->lock is registered as a queue lock.)
Thanks for reminding me
Hi Pete,
On Thu, 13 Dec 2007 13:59:16 -0800, Pete Zaitcev <[EMAIL PROTECTED]> wrote:
> > > > - end_that_request_first(rq, uptodate, rq->hard_nr_sectors);
> > > > - end_that_request_last(rq, uptodate);
> > > > + if (__blk_end_request(rq, error, blk_rq_bytes(rq)))
> > > > +
On Wed, 12 Dec 2007 15:38:15 -0500 (EST), Kiyoshi Ueda <[EMAIL PROTECTED]>
wrote:
> On Tue, 11 Dec 2007 15:48:03 -0800, Pete Zaitcev <[EMAIL PROTECTED]> wrote:
> > > - end_that_request_first(rq, uptodate, rq->hard_nr_sectors);
> > > - end_that_request_last(rq, uptodate);
> > > + if (__blk_end_req
Hi Pete,
On Tue, 11 Dec 2007 15:48:03 -0800, Pete Zaitcev <[EMAIL PROTECTED]> wrote:
> > if (scsi_status == 0) {
> > - uptodate = 1;
> > + error = 0;
> > } else {
> > - uptodate = 0;
> > + error = -EIO;
> > rq->errors = scsi_status;
> >
On Tue, 11 Dec 2007 17:46:47 -0500 (EST), Kiyoshi Ueda <[EMAIL PROTECTED]>
wrote:
> if (scsi_status == 0) {
> - uptodate = 1;
> + error = 0;
> } else {
> - uptodate = 0;
> + error = -EIO;
> rq->errors = scsi_status;
>
This patch converts ub to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
Cc: Pete Zaitcev <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/block/ub.c | 10 +-
1 file
6 matches
Mail list logo