Re: [PATCH 2/4] block: Avoid that request_fn is invoked on a dead queue

2012-10-24 Thread Tejun Heo
Hello, Bart. On Tue, Oct 23, 2012 at 02:11:29PM +0200, Bart Van Assche wrote: > >__blk_run_queue_uncond() is a cold path and I don't think adding a > >test there matters but I think it would be better if we avoid an extra > >branch if possible for __blk_run_queue(). Can't we merge > >blk_queue_st

Re: [PATCH 2/4] block: Avoid that request_fn is invoked on a dead queue

2012-10-23 Thread Bart Van Assche
On 10/17/12 01:38, Tejun Heo wrote: /** + * __blk_run_queue_uncond - run a queue whether or not it has been stopped + * @q: The queue to run + * + * Description: + *Invoke request handling on a queue if there are any pending requests. + *May be used to restart request handling after a r

Re: [PATCH 2/4] block: Avoid that request_fn is invoked on a dead queue

2012-10-16 Thread Tejun Heo
Hello, On Wed, Oct 10, 2012 at 05:08:01PM +0200, Bart Van Assche wrote: > A block driver may start cleaning up resources needed by its > request_fn as soon as blk_cleanup_queue() finished, so request_fn > must not be invoked after draining finished. Can you please make the commit message more ver

[PATCH 2/4] block: Avoid that request_fn is invoked on a dead queue

2012-10-10 Thread Bart Van Assche
A block driver may start cleaning up resources needed by its request_fn as soon as blk_cleanup_queue() finished, so request_fn must not be invoked after draining finished. Cc: James Bottomley Cc: Mike Christie Cc: Jens Axboe Cc: Tejun Heo Cc: Chanho Min Signed-off-by: Bart Van Assche --- bl