> >
> > -buf = gdth_ioctl_alloc(ha, GDTH_SCRATCH, FALSE, );
> > if (!buf)
> > goto stop_output;
>
> I think this !buf test is redundant.
Thanks,
fixed.
On Thu, 18 Oct 2018, Christoph Hellwig wrote:
> gdth_show_info currently allocs and frees a dma buffer four times,
> which isn't very efficient. Reuse a single allocation instead.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/gdth_proc.c | 18 +-
> 1 file changed, 5
gdth_show_info currently allocs and frees a dma buffer four times,
which isn't very efficient. Reuse a single allocation instead.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth_proc.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git
3 matches
Mail list logo