Re: [PATCH 2/4] gdth: reuse dma coherent allocation in gdth_show_info

2018-11-09 Thread Christoph Hellwig
> > > > -buf = gdth_ioctl_alloc(ha, GDTH_SCRATCH, FALSE, ); > > if (!buf) > > goto stop_output; > > I think this !buf test is redundant. Thanks, fixed.

Re: [PATCH 2/4] gdth: reuse dma coherent allocation in gdth_show_info

2018-10-18 Thread Finn Thain
On Thu, 18 Oct 2018, Christoph Hellwig wrote: > gdth_show_info currently allocs and frees a dma buffer four times, > which isn't very efficient. Reuse a single allocation instead. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/gdth_proc.c | 18 +- > 1 file changed, 5

[PATCH 2/4] gdth: reuse dma coherent allocation in gdth_show_info

2018-10-18 Thread Christoph Hellwig
gdth_show_info currently allocs and frees a dma buffer four times, which isn't very efficient. Reuse a single allocation instead. Signed-off-by: Christoph Hellwig --- drivers/scsi/gdth_proc.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git