Re: [PATCH 2/4] scsi: remove scsi_end_request

2014-05-08 Thread Hannes Reinecke
On 05/01/2014 04:51 PM, Christoph Hellwig wrote: By folding scsi_end_request into its only caller we can significantly clean up the completion logic. We can use simple goto labels now to only have a single place to finish or requeue command there instead of the previous convoluted logic. Signed

[PATCH 2/4] scsi: remove scsi_end_request

2014-05-01 Thread Christoph Hellwig
By folding scsi_end_request into its only caller we can significantly clean up the completion logic. We can use simple goto labels now to only have a single place to finish or requeue command there instead of the previous convoluted logic. Signed-off-by: Christoph Hellwig Reviewed-by: Nicholas B

Re: [PATCH 2/4] scsi: remove scsi_end_request

2014-03-30 Thread Nicholas A. Bellinger
Hi hch & jejb, On Thu, 2014-03-27 at 17:14 +0100, Christoph Hellwig wrote: > Simply the I/O completion logic by folding scsi_end_request into its only > caller. There is a single site to either requeue the command or move on > to the next one instead of of the previous convoluted logic. > > Sign

[PATCH 2/4] scsi: remove scsi_end_request

2014-03-27 Thread Christoph Hellwig
Simply the I/O completion logic by folding scsi_end_request into its only caller. There is a single site to either requeue the command or move on to the next one instead of of the previous convoluted logic. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_lib.c | 114 +---