On Wed, 2007-01-10 at 08:10 -0800, James Bottomley wrote:
> On Tue, 2007-01-09 at 16:32 -0500, Edward Goggin wrote:
> > The attached (untested) patch shows a VMware and scsi transport agnostic
> > approach which introduces a new host status (DID_QUALIFIED_REQUEUE) to
> > be used by mptscsih.c (and
On Tue, 2007-01-09 at 16:32 -0500, Edward Goggin wrote:
> The attached (untested) patch shows a VMware and scsi transport agnostic
> approach which introduces a new host status (DID_QUALIFIED_REQUEUE) to
> be used by mptscsih.c (and other LLDs) instead of DID_BUS_BUSY. A host
> status of DID_QUALI
On Tuesday, January 09, 2007 2:33 PM, Edward Goggin wrote:
> multi-pathing. This requirement shouldn't be a problem for the IBM
> RDAC/MPP driver either since it should already be setting the
> REQ_FAILFAST attribute of I/Os for which it is providing
> multi-pathing,
> similar to what the Linux
eed; Moore, Eric; David Berghoff
> > Cc: James Bottomley; Adam Zimman; linux-scsi@vger.kernel.org; Shirron,
> > Stephen
> > Subject: Re: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries
> >
> > Hmm why don't w make the whole thing configurable (dav
: Re: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries
Hmm why don't w make the whole thing configurable (david implemented this
for us)
In that case I would prefer going on with automatic detection of our
implementation - see first part of attached mpt-patch.diff I offered
Hmm why don't w make the whole thing configurable (david implemented
this for us)
+/*
+ * cmd line parameters
+ */
+static int mpt_mpi_busy;
+module_param(mpt_mpi_busy, int, 0);
+MODULE_PARM_DESC(mpt_mpi_busy, " MPT MPI busy workaround for VMWare ESX
(default=0)");
+
/*=-=-=-=-=-=-=-=-=
: vmware bug fix prevent inifinite retries
Hmm why don't w make the whole thing configurable (david implemented
this for us)
+/*
+ * cmd line parameters
+ */
+static int mpt_mpi_busy;
+module_param(mpt_mpi_busy, int, 0);
+MODULE_PARM_DESC(mpt_mpi_busy, " MPT MPI busy workaround
Moore, Eric wrote:
> On Monday, January 08, 2007 3:25 PM, James Bottomley wrote:
>
>> Right, I sort of suspected something like this. BUSY/QUEUE_FULL
>> handling was a bit iffy in 2.4; but it was sorted out in the 2003/4
>> timeframe. Nowadays, I think you want to translate the
>> MPI_SCSI_ST
On Monday, January 08, 2007 3:25 PM, James Bottomley wrote:
> Right, I sort of suspected something like this. BUSY/QUEUE_FULL
> handling was a bit iffy in 2.4; but it was sorted out in the 2003/4
> timeframe. Nowadays, I think you want to translate the
> MPI_SCSI_STATUS_BUSY directly to SAM_STA
On Mon, 2007-01-08 at 15:03 -0700, Moore, Eric wrote:
> In the 03.02.19, we add added the current logic for the following
> reason:
>
> "When a target device responds with BUSY status, the MPT driver was
> sending DID_OK to the
> SCSI mid layer, which caused the IO to be retried indefinitely betw
On Saturday, January 06, 2007 8:31 AM, James Bottomley wrote:
>
> DID_BUS_BUSY causes an immediate retry, but it does debit the retry
> count, so it shouldn't cause "infinite retries" ... if it
> does, there's
> something else wrong here.
>
> I should also point out that the MPI_SCSI_STATUS_BU
On Sat, 2007-01-06 at 09:10 -0700, Matthew Wilcox wrote:
> On Sat, Jan 06, 2007 at 09:30:45AM -0600, James Bottomley wrote:
> > On Thu, 2007-01-04 at 20:46 -0700, Eric Moore wrote:
> > > - if (scsi_status == MPI_SCSI_STATUS_BUSY)
> > > + if (ioc->bus_type != SPI && s
On Sat, Jan 06, 2007 at 09:30:45AM -0600, James Bottomley wrote:
> On Thu, 2007-01-04 at 20:46 -0700, Eric Moore wrote:
> > - if (scsi_status == MPI_SCSI_STATUS_BUSY)
> > + if (ioc->bus_type != SPI && scsi_status ==
> > MPI_SCSI_STATUS_BUSY)
> >
On Thu, 2007-01-04 at 20:46 -0700, Eric Moore wrote:
> - if (scsi_status == MPI_SCSI_STATUS_BUSY)
> + if (ioc->bus_type != SPI && scsi_status ==
> MPI_SCSI_STATUS_BUSY)
> sc->result = (DID_BUS_BUSY << 16) | scsi_status;
>
Simialar to the previous bug fix, this patch avoids
inifinite retries. This is replicated in Vmware environment
when the guest OS is using the 53c1030 as a emulated storage controller.
This patch will restore original driver behavior for SPI from about
a year ago, though keeping same behavor for FC
15 matches
Mail list logo
