Re: [PATCH 2/6] blk-mq: call blk_mq_start_request from ->queue_rq

2014-09-15 Thread Ming Lei
On Sun, Sep 14, 2014 at 7:40 AM, Christoph Hellwig wrote: > When we call blk_mq_start_request from the core blk-mq code before calling > into > ->queue_rq there is a racy window where the timeout handler can hit before > we've > fully set up the driver specific part of the command. One problem

Re: [PATCH 2/6] blk-mq: call blk_mq_start_request from ->queue_rq

2014-09-14 Thread Ming Lei
On Sun, Sep 14, 2014 at 7:40 AM, Christoph Hellwig wrote: > When we call blk_mq_start_request from the core blk-mq code before calling > into > ->queue_rq there is a racy window where the timeout handler can hit before > we've > fully set up the driver specific part of the command. It is quite

[PATCH 2/6] blk-mq: call blk_mq_start_request from ->queue_rq

2014-09-13 Thread Christoph Hellwig
When we call blk_mq_start_request from the core blk-mq code before calling into ->queue_rq there is a racy window where the timeout handler can hit before we've fully set up the driver specific part of the command. Move the call to blk_mq_start_request into the driver so the driver can start the r