Re: [PATCH 21/43] qla2xxx: Remove calling cancel_work_sync()

2017-12-20 Thread Madhani, Himanshu
> On Dec 20, 2017, at 10:56 AM, Bart Van Assche wrote: > > On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote: >> @@ -1234,8 +1234,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port >> *sess, >> ql_dbg(ql_dbg_tgt, sess->vha, 0xe001, >> "Scheduling sess %p for deletion\

Re: [PATCH 21/43] qla2xxx: Remove calling cancel_work_sync()

2017-12-20 Thread Bart Van Assche
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote: > @@ -1234,8 +1234,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port > *sess, > ql_dbg(ql_dbg_tgt, sess->vha, 0xe001, > "Scheduling sess %p for deletion\n", sess); > > - /* use cancel to push work element throug

[PATCH 21/43] qla2xxx: Remove calling cancel_work_sync()

2017-12-19 Thread Himanshu Madhani
From: Sawan Chandak This is blocking call and issue is seen, when called in interrupt context. __cancel_work_timer+0x140/0x210 ? ql_dbg+0xcb/0x110 [qla2xxx] cancel_work_sync+0x10/0x20 qlt_schedule_sess_for_deletion+0x89/0x170 [qla2xxx] qla24xx_handle_gpnid_event+0x146/0x4a0 [qla2xxx] qla2x00_fcp