On 03/31/16 08:26, Quinn Tran wrote:
Agreed. It’s one of our pending action items for cleanup.
Hello Quinn,
Thanks for the feedback. I will drop my patch.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More
Quinn Tran
, Christoph Hellwig , linux-scsi
Subject: [PATCH 3/3] qla2xxx: Assign names to the flags in cmd_flags
>Use a C bitfield instead of emulating this functionality with
>bit manipulations. Since only bits 5, 16 and 20 are ever tested,
>remove the code that sets the other bits. Thi
linux-scsi
Subject: Re: [PATCH 3/3] qla2xxx: Assign names to the flags in cmd_flags
>On 03/31/16 08:16, Quinn Tran wrote:
>> We use these flags for debugging purpose in crash cases.
>
>Hello Quinn,
>
>It must be inconvenient to have to look up the meaning of the individual
>b
On 03/31/16 08:16, Quinn Tran wrote:
We use these flags for debugging purpose in crash cases.
Hello Quinn,
It must be inconvenient to have to look up the meaning of the individual
bits of the cmd_flags variable when analyzing a kernel crash. How about
preserving all these flags and to assign
On 2016-03-31 01:26, Bart Van Assche wrote:
Use a C bitfield instead of emulating this functionality with
bit manipulations. Since only bits 5, 16 and 20 are ever tested,
remove the code that sets the other bits. This is easy to verify
by running the following command:
$ git grep -nH 'BIT_[0-9]'
Use a C bitfield instead of emulating this functionality with
bit manipulations. Since only bits 5, 16 and 20 are ever tested,
remove the code that sets the other bits. This is easy to verify
by running the following command:
$ git grep -nH 'BIT_[0-9]' drivers/scsi/qla2xxx | grep cmd_flags
Signed
6 matches
Mail list logo
