Re: [PATCH 3/3] sd: error handling synchronizing caches

2012-08-01 Thread Mike Christie
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index a344220..49b0c52 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -1278,8 +1278,32 @@ static int sd_sync_cache(struct scsi_disk *sdkp) > > if (res) { > sd_print_result(sdkp, res); > + > i

Re: [PATCH 3/3] sd: error handling synchronizing caches

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 16:44 +0200, Oliver Neukum wrote: > sd_sync_cache() can fail in several manners. > As the error return is passed to the generic layer, > it must be correctly processed. > > Failures due to unplugged devices or removed media > should be ignored. In the other cases retryable an

[PATCH 3/3] sd: error handling synchronizing caches

2012-08-01 Thread Oliver Neukum
sd_sync_cache() can fail in several manners. As the error return is passed to the generic layer, it must be correctly processed. Failures due to unplugged devices or removed media should be ignored. In the other cases retryable and fatal errors must be differentiated. This fixes a problem with un