Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-11-03 Thread Finn Thain
On Thu, 3 Nov 2016, Ondrej Zary wrote: > On Thursday 03 November 2016, Finn Thain wrote: > > On Wed, 2 Nov 2016, Ondrej Zary wrote: > > > > > > The card is almost Plug&Play. The base address is already configured > > > automatically by the driver so doing the same for IRQ makes sense. > > > > W

Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-11-03 Thread Ondrej Zary
On Thursday 03 November 2016, Finn Thain wrote: > On Wed, 2 Nov 2016, Ondrej Zary wrote: > > > Also, you've ignored the irq module parameters. From the user's point > > > of view, surely the least surprising thing is to attempt to configure > > > the card for whatever irq the user asked for. > > >

Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-11-02 Thread Finn Thain
On Wed, 2 Nov 2016, Ondrej Zary wrote: > > Also, you've ignored the irq module parameters. From the user's point > > of view, surely the least surprising thing is to attempt to configure > > the card for whatever irq the user asked for. > > I haven't. NCR5380_find_irq is only called when irq i

Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-11-02 Thread Ondrej Zary
On Wednesday 02 November 2016, Finn Thain wrote: > On Mon, 31 Oct 2016, Ondrej Zary wrote: > > Find free and working IRQ automatically on HP C2502 cards. > > Also allow IRQ 9 to work (aliases to IRQ 2 on the card). > > > > Signed-off-by: Ondrej Zary > > --- > > drivers/scsi/g_NCR5380.c | 29 +++

Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-11-02 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > Find free and working IRQ automatically on HP C2502 cards. > Also allow IRQ 9 to work (aliases to IRQ 2 on the card). > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/g_NCR5380.c | 29 +++-- > 1 file changed, 27 insertions(

[PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-10-31 Thread Ondrej Zary
Find free and working IRQ automatically on HP C2502 cards. Also allow IRQ 9 to work (aliases to IRQ 2 on the card). Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/g_NCR5380.