Re: [PATCH 4/7] qla2xxx: Added change to enable ZIO for FC-NVMe devices

2017-07-20 Thread Madhani, Himanshu
> On Jul 20, 2017, at 12:00 AM, Johannes Thumshirn wrote: > > On Wed, Jul 19, 2017 at 11:51:48AM -0700, Himanshu Madhani wrote: >> +mcp->out_mb = MBX_2|MBX_1|MBX_0; >> +mcp->in_mb = MBX_2|MBX_0; > > Please add spaces around the '|'. Checkpatch should've warned you

Re: [PATCH 4/7] qla2xxx: Added change to enable ZIO for FC-NVMe devices

2017-07-20 Thread Johannes Thumshirn
On Wed, Jul 19, 2017 at 11:51:48AM -0700, Himanshu Madhani wrote: > + mcp->out_mb = MBX_2|MBX_1|MBX_0; > + mcp->in_mb = MBX_2|MBX_0; Please add spaces around the '|'. Checkpatch should've warned you about that. > + mcp->tov = MBX_TOV_SECONDS; > + mcp->flags = 0; > + > + rval

[PATCH 4/7] qla2xxx: Added change to enable ZIO for FC-NVMe devices

2017-07-19 Thread Himanshu Madhani
From: Duane Grigsby Add support to the driver to set the exchange threshold value for the number of outstanding AENs. Signed-off-by: Duane Grigsby Signed-off-by: Darren Trapp Signed-off-by: Anil Gurumurthy