Re: [PATCH 4/9] qla2xxx: don't break the bsg-lib abstractions

2017-10-05 Thread Madhani, Himanshu
> On Oct 3, 2017, at 3:48 AM, Christoph Hellwig wrote: > > Always use bsg_job->reply instead of scsi_req(bsg_job->req)->sense), as > they always point to the same memory. > > Never set scsi_req(bsg_job->req)->result and we'll set that value through > bsg_job_done. > > Signed-off-by: Christoph

Re: [PATCH 4/9] qla2xxx: don't break the bsg-lib abstractions

2017-10-04 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Ke

Re: [PATCH 4/9] qla2xxx: don't break the bsg-lib abstractions

2017-10-03 Thread Hannes Reinecke
On 10/03/2017 12:48 PM, Christoph Hellwig wrote: > Always use bsg_job->reply instead of scsi_req(bsg_job->req)->sense), as > they always point to the same memory. > > Never set scsi_req(bsg_job->req)->result and we'll set that value through > bsg_job_done. > > Signed-off-by: Christoph Hellwig >

[PATCH 4/9] qla2xxx: don't break the bsg-lib abstractions

2017-10-03 Thread Christoph Hellwig
Always use bsg_job->reply instead of scsi_req(bsg_job->req)->sense), as they always point to the same memory. Never set scsi_req(bsg_job->req)->result and we'll set that value through bsg_job_done. Signed-off-by: Christoph Hellwig --- drivers/scsi/qla2xxx/qla_bsg.c | 10 -- drivers/scsi