Re: [PATCH 5/9] sd: Cleanup sd_done sense data handling

2017-04-23 Thread Damien Le Moal
Bart, On 4/22/17 03:41, Bart Van Assche wrote: > On Fri, 2017-04-21 at 18:16 +0900, damien.lem...@wdc.com wrote: >> @@ -1884,8 +1886,6 @@ static int sd_done(struct scsi_cmnd *SCpnt) >>else { >>sdkp->device->no_write_same = 1;

Re: [PATCH 5/9] sd: Cleanup sd_done sense data handling

2017-04-21 Thread Bart Van Assche
On Fri, 2017-04-21 at 18:16 +0900, damien.lem...@wdc.com wrote: > @@ -1884,8 +1886,6 @@ static int sd_done(struct scsi_cmnd *SCpnt) > else { > sdkp->device->no_write_same = 1; > sd_config_write

[PATCH 5/9] sd: Cleanup sd_done sense data handling

2017-04-21 Thread damien . lemoal
From: Damien Le Moal In sd_done(), for the ILLEGAL REQUEST sense key case, add an 'else' after the first 'if (sshdr.asc == 0x10)' test to avoid the second test (the values tested are different). Still for the same ILLEGAL REQUEST case, move the declarations of the variables 'op' and 'unmap' with