RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-12 Thread KY Srinivasan
@parallels.com; jasow...@redhat.com; a...@canonical.com; > linux-scsi@vger.kernel.org > Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler > > On Thu, Jul 10, 2014 at 12:33 PM, Richard Weinberger > wrote: > > On Wed, Jul 9, 2014 at 8:51 PM, KY Sriniv

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-12 Thread Richard Weinberger
AM >>> To: KY Srinivasan >>> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; >>> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; >>> a...@canonical.com; linux-scsi@vger.kernel.org >>> Subject: Re: [PATCH 6/8] Drivers: scsi: sto

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-11 Thread KY Srinivasan
..@redhat.com; > a...@canonical.com; linux-scsi@vger.kernel.org > Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler > > On 07/11/2014 12:26 AM, KY Srinivasan wrote: > > > > > >> -Original Message- > >> From: Christoph Hellwig [mai

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-11 Thread Christoph Hellwig
On Fri, Jul 11, 2014 at 11:52:55AM +0200, Hannes Reinecke wrote: > Something like this should be sufficient: Right. That plus a detailed comment explaining why it's there.. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.o

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-11 Thread Hannes Reinecke
...@parallels.com; jasow...@redhat.com; a...@canonical.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler Note that you could increase the timeout and/or implement an eh_timed_out handler that just returns BLK_EH_RESET_TIMER, but if the

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-10 Thread KY Srinivasan
; jasow...@redhat.com; a...@canonical.com; > linux-scsi@vger.kernel.org > Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler > > > Note that you could increase the timeout and/or implement an > eh_timed_out handler that just returns BLK_EH_RESET_TIMER, but

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-10 Thread Richard Weinberger
iverproject.org; >> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; >> a...@canonical.com; linux-scsi@vger.kernel.org >> Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler >> >> On Tue, Jul 08, 2014 at 05:46:50PM -0700, K. Y. Srinivas

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-10 Thread Christoph Hellwig
On Wed, Jul 09, 2014 at 06:51:38PM +, KY Srinivasan wrote: > On Azure, we sometimes have unbounded I/O latencies and some distributions > (such as SLES12) based on recent kernels are invoking the "Abort Handler". Any kernel will invoke the abort handler if present, and then escalate to the var

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-09 Thread KY Srinivasan
t; a...@canonical.com; linux-scsi@vger.kernel.org > Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler > > On Tue, Jul 08, 2014 at 05:46:50PM -0700, K. Y. Srinivasan wrote: > > Implement a simple abort handler. The host does not support "Abort"; &g

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:50PM -0700, K. Y. Srinivasan wrote: > Implement a simple abort handler. The host does not support "Abort"; just > ensure that all inflight I/Os have been accounted for. The abort handler should abort a single command, not wait for all of them. What issue do you see t

[PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-08 Thread K. Y. Srinivasan
Implement a simple abort handler. The host does not support "Abort"; just ensure that all inflight I/Os have been accounted for. Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/s