Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread Tejun Heo
Hello, Rusty Russell. Rusty Russell wrote: ATA relies so heavily on scsi that it needs to be converted at the same time. ATA adds padding to scatterlists in scsi commands, but because there was no good way of appending to those scatterlists, it had to use boutique iterators to make sure

Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread James Bottomley
On Wed, 2007-12-26 at 17:36 +0900, Tejun Heo wrote: (PS, I haven't followed the sg chaining discussion. Why is sg chaining an optional feature? Performance overhead on low end machines?) The idea of SG chaining is to allow drivers that wish to take advantage of it to increase their transfer

Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread Tejun Heo
Hello, Rusty. Rusty Russell wrote: On Wednesday 26 December 2007 19:36:36 Tejun Heo wrote: It would be better to build upon sg chaining as we already have it. I think it can be made much easier with a bit more safe guards, generalization and some helpers. I did this work to replace sg

[PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-18 Thread Rusty Russell
ATA relies so heavily on scsi that it needs to be converted at the same time. ATA adds padding to scatterlists in scsi commands, but because there was no good way of appending to those scatterlists, it had to use boutique iterators to make sure the padding is included. With sg_ring, ATA can