Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-22 Thread Christoph Hellwig
Hi Bart, I like these changes modulo the minor comments we had. One thing that is missing is generation multiqueue-aware tags at the blk-mq level, which should be as simple as always adding a queue prefix in the tag allocation code. Did you consider switching srp to use the block layer provided

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-22 Thread Jens Axboe
On 2014-09-22 10:25, Bart Van Assche wrote: On 22/09/2014 8:37, Christoph Hellwig wrote: One thing that is missing is generation multiqueue-aware tags at the blk-mq level, which should be as simple as always adding a queue prefix in the tag allocation code. Hello Christoph, Adding a queue

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-22 Thread Jens Axboe
On 2014-09-22 10:31, Jens Axboe wrote: On 2014-09-22 10:25, Bart Van Assche wrote: On 22/09/2014 8:37, Christoph Hellwig wrote: One thing that is missing is generation multiqueue-aware tags at the blk-mq level, which should be as simple as always adding a queue prefix in the tag allocation

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-22 Thread Bart Van Assche
On 22/09/2014 8:37, Christoph Hellwig wrote: One thing that is missing is generation multiqueue-aware tags at the blk-mq level, which should be as simple as always adding a queue prefix in the tag allocation code. Hello Christoph, Adding a queue prefix in the tag allocation code is an

[PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-19 Thread Bart Van Assche
Hello, Although the SRP protocol supports multichannel operation, although since considerable time RDMA HCA's are available that support multiple completion vectors and although multichannel operation yields better performance than using a single channel, the Linux SRP initiator does not yet

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-19 Thread Bart Van Assche
[PATCH 1/8] blk-mq: Use all available hardware queues Suppose that a system has two CPU sockets, three cores per socket, that it does not support hyperthreading and that four hardware queues are provided by a block driver. With the current algorithm this will lead to the following assignment of

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-19 Thread Sagi Grimberg
On 9/19/2014 3:56 PM, Bart Van Assche wrote: [PATCH 1/8] blk-mq: Use all available hardware queues Suppose that a system has two CPU sockets, three cores per socket, that it does not support hyperthreading and that four hardware queues are provided by a block driver. With the current

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-19 Thread Jens Axboe
On 09/19/2014 06:55 AM, Bart Van Assche wrote: Hello, Although the SRP protocol supports multichannel operation, although since considerable time RDMA HCA's are available that support multiple completion vectors and although multichannel operation yields better performance than using a