Re: [PATCH V3 10/16] scsi: ufs: add UFS power management support

2014-09-21 Thread Dolev Raviv
Hi Kiran, Thanks for bringing it to my attention. Fortunately I already noticed it and fixed it. It will be sent soon when all comments on this series are addressed. Thanks, Dolev > Hi Dolev, > > On Wednesday 10 September 2014 05:24 PM, Dolev Raviv wrote: >> From: Subhash Jadavani >> >> This pat

Re: [PATCH V3 10/16] scsi: ufs: add UFS power management support

2014-09-18 Thread Kiran Padwal
Hi Dolev, On Wednesday 10 September 2014 05:24 PM, Dolev Raviv wrote: > From: Subhash Jadavani > > This patch adds support for UFS device and UniPro link power management > during runtime/system PM. > > +vccq_lpm: > + ufshcd_config_vreg_lpm(hba, hba->vreg_info.vccq); > +vcc_disable: > +

Re: [PATCH V3 10/16] scsi: ufs: add UFS power management support

2014-09-16 Thread Akinobu Mita
2014-09-10 20:54 GMT+09:00 Dolev Raviv : > +static int ufshcd_config_vreg_load(struct device *dev, struct ufs_vreg *vreg, > + int ua) > +{ > + int ret = 0; > + struct regulator *reg = vreg->reg; > + const char *name = vreg->name; > + > + BUG_

Re: [PATCH V3 10/16] scsi: ufs: add UFS power management support

2014-09-15 Thread Dolev Raviv
> 2014-09-10 20:54 GMT+09:00 Dolev Raviv : >> +static inline void ufshcd_enable_irq(struct ufs_hba *hba) >> +{ >> + if (!hba->is_irq_enabled) { >> + enable_irq(hba->irq); >> + hba->is_irq_enabled = true; >> + } >> +} >> + >> +static inline void ufshcd_disabl

Re: [PATCH V3 10/16] scsi: ufs: add UFS power management support

2014-09-10 Thread Akinobu Mita
2014-09-10 20:54 GMT+09:00 Dolev Raviv : > +static inline void ufshcd_enable_irq(struct ufs_hba *hba) > +{ > + if (!hba->is_irq_enabled) { > + enable_irq(hba->irq); > + hba->is_irq_enabled = true; > + } > +} > + > +static inline void ufshcd_disable_irq(struct

[PATCH V3 10/16] scsi: ufs: add UFS power management support

2014-09-10 Thread Dolev Raviv
From: Subhash Jadavani This patch adds support for UFS device and UniPro link power management during runtime/system PM. Main idea is to define multiple UFS low power levels based on UFS device and UFS link power states. This would allow any specific platform or pci driver to choose the best sui