Re: [PATCH scsi-misc-2.6 09/13] scsi: in scsi_prep_fn(), remove bogus comments & clean up

2005-03-31 Thread Tejun Heo
Hello, James. On Thu, Mar 31, 2005 at 12:02:20PM -0600, James Bottomley wrote: > On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote: > > -* come up when there is a medium error. We have to treat > > -* these two cases differently. We differentiate by looking > > -* at request->cmd,

Re: [PATCH scsi-misc-2.6 09/13] scsi: in scsi_prep_fn(), remove bogus comments & clean up

2005-03-31 Thread James Bottomley
On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote: > - * come up when there is a medium error. We have to treat > - * these two cases differently. We differentiate by looking > - * at request->cmd, as this tells us the real story. > + * come up when there is a medium error.

Re: [PATCH scsi-misc-2.6 09/13] scsi: in scsi_prep_fn(), remove bogus comments & clean up

2005-03-31 Thread Christoph Hellwig
> - /* > - * This sets up the scatter-gather table (allocating if > - * required). > - */ > + /* This sets up the scatter-gather table (allocating if > + * required). */ the old comment style is the preferred in linux, pl

Re: [PATCH scsi-misc-2.6 09/13] scsi: in scsi_prep_fn(), remove bogus comments & clean up

2005-03-31 Thread Tejun Heo
09_scsi_prep_fn_comment_update.patch Remove bogus comments from scsi_prep_fn() and clean up a bit. While at it, remove leading and tailing empty comment lines for one or two liners to make the code more concise. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> scsi_lib.c |