Re: [PATCH v2] Use blist_flags_t consistently

2017-12-12 Thread Bart Van Assche
On Tue, 2017-12-12 at 08:52 +0100, Christoph Hellwig wrote: > On Mon, Dec 11, 2017 at 04:08:03PM -0800, Bart Van Assche wrote: > > + if (!((__force unsigned int)sdev->sdev_bflags & BIT(i))) > > I'd case the right side argument to __force blist_flags_t here for > purely esthetic reasons.

Re: [PATCH v2] Use blist_flags_t consistently

2017-12-11 Thread Christoph Hellwig
On Mon, Dec 11, 2017 at 04:08:03PM -0800, Bart Van Assche wrote: > + if (!((__force unsigned int)sdev->sdev_bflags & BIT(i))) I'd case the right side argument to __force blist_flags_t here for purely esthetic reasons. Except for that this looks fine to me: Reviewed-by: Christoph Hel

[PATCH v2] Use blist_flags_t consistently

2017-12-11 Thread Bart Van Assche
Use the type blist_flags_t for all variables that represent blacklist flags. Additionally, suppress recently introduced sparse warnings related to blacklist flags. Fixes: commit c6b54164508a ("scsi: Use 'blist_flags_t' for scsi_devinfo flags") Signed-off-by: Bart Van Assche Cc: Christoph Hellwig