Re: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

2016-10-06 Thread Subhash Jadavani
On 2016-10-06 18:16, Kiwoong Kim wrote: Hi, Subhash. Thanks Kim for the response. On 2016-10-06 03:28, Kiwoong Kim wrote: > Hi, Subhash. > > Some UFS host controllers may need to call the vendor specific > callback before and after controlling by clock control framework, > regardless of whethe

RE: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

2016-10-06 Thread Kiwoong Kim
Hi, Subhash. > Thanks Kim for the response. > > On 2016-10-06 03:28, Kiwoong Kim wrote: > > Hi, Subhash. > > > > Some UFS host controllers may need to call the vendor specific > > callback before and after controlling by clock control framework, > > regardless of whether available clocks are turn

Re: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

2016-10-06 Thread Subhash Jadavani
Thanks Kim for the response. On 2016-10-06 03:28, Kiwoong Kim wrote: Hi, Subhash. Some UFS host controllers may need to call the vendor specific callback before and after controlling by clock control framework, regardless of whether available clocks are turned on or off. Are you suggesting to

RE: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

2016-10-06 Thread Kiwoong Kim
Hi, Subhash. Some UFS host controllers may need to call the vendor specific callback before and after controlling by clock control framework, regardless of whether available clocks are turned on or off. Is there any special reason to limit to invoke the callback only when the clocks are turned on

[PATCH v2] scsi: ufshcd: fix possible unclocked register access

2016-10-05 Thread Subhash Jadavani
Vendor specific setup_clocks callback may require the clocks managed by ufshcd driver to be ON. So if the vendor specific setup_clocks callback is called while the required clocks are turned off, it could result into unclocked register access. To prevent possible unclock register access, this chan