Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > That was my plan. Does that sound okay? Yep, that's fine. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Kees Cook
On Tue, Oct 31, 2017 at 10:42 AM, Martin K. Petersen wrote: > > Bart, > >> The tree I tested indeed includes that rebased patch. BTW, since the code >> touched by that patch has not been modified in the past months, the rebased >> patch is identical to the patch I posted in May 2017. > > OK. Just

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Bart, > The tree I tested indeed includes that rebased patch. BTW, since the code > touched by that patch has not been modified in the past months, the rebased > patch is identical to the patch I posted in May 2017. OK. Just checking. So what's the plan here? Should both patches be routed throu

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Bart Van Assche
On Tue, 2017-10-31 at 13:20 -0400, Martin K. Petersen wrote: > > That tree passed the iSCSI target tests I ran so feel free to add my > > Reviewed-by and Tested-by to [PATCH v2] target/iscsi: Convert timers > > to use timer_setup(). > > Is that with your rebased patch fro

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Bart, > That tree passed the iSCSI target tests I ran so feel free to add my > Reviewed-by and Tested-by to [PATCH v2] target/iscsi: Convert timers > to use timer_setup(). Is that with your rebased patch from a few days ago? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Bart Van Assche
rnel/git/kees/linux.git/log/?h=kspp/timer/tip/target Hello Kees, That tree passed the iSCSI target tests I ran so feel free to add my Reviewed-by and Tested-by to [PATCH v2] target/iscsi: Convert timers to use timer_setup(). Bart.

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche wrote: > On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer pointer e

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-27 Thread Bart Van Assche
On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Includes a fix for correcting an > on-stack timer u

[PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-27 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Includes a fix for correcting an on-stack timer usage. Cc: "Nicholas A. Bellinger" Cc: Bart Van Assche Cc: