Re: [PATCH v2 08/16] iscsi-target: add void (*iscsit_get_r2t_ttt)()

2016-04-13 Thread Varun Prakash
On Wed, Apr 13, 2016 at 12:52:11PM +0300, Sagi Grimberg wrote: > > >>>Add void (*iscsit_get_r2t_ttt)() to > >>>struct iscsit_transport, iscsi-target > >>>uses this callback to get > >>>r2t->targ_xfer_tag. > >> > >>Your driver allocates ttt's? That looks like bad > >>layering to me. This

Re: [PATCH v2 08/16] iscsi-target: add void (*iscsit_get_r2t_ttt)()

2016-04-13 Thread Sagi Grimberg
Add void (*iscsit_get_r2t_ttt)() to struct iscsit_transport, iscsi-target uses this callback to get r2t->targ_xfer_tag. Your driver allocates ttt's? That looks like bad layering to me. This definitely deserves an explanation... cxgbit.ko allocates ttt only for r2t pdus to do Direct Data

Re: [PATCH v2 08/16] iscsi-target: add void (*iscsit_get_r2t_ttt)()

2016-04-11 Thread Varun Prakash
On Sun, Apr 10, 2016 at 08:51:44PM +0300, Sagi Grimberg wrote: > > >Add void (*iscsit_get_r2t_ttt)() to > >struct iscsit_transport, iscsi-target > >uses this callback to get > >r2t->targ_xfer_tag. > > Your driver allocates ttt's? That looks like bad > layering to me. This definitely deserves an

Re: [PATCH v2 08/16] iscsi-target: add void (*iscsit_get_r2t_ttt)()

2016-04-10 Thread Sagi Grimberg
Add void (*iscsit_get_r2t_ttt)() to struct iscsit_transport, iscsi-target uses this callback to get r2t->targ_xfer_tag. Your driver allocates ttt's? That looks like bad layering to me. This definitely deserves an explanation... -- To unsubscribe from this list: send the line "unsubscribe

[PATCH v2 08/16] iscsi-target: add void (*iscsit_get_r2t_ttt)()

2016-04-09 Thread Varun Prakash
Add void (*iscsit_get_r2t_ttt)() to struct iscsit_transport, iscsi-target uses this callback to get r2t->targ_xfer_tag. Signed-off-by: Varun Prakash --- drivers/target/iscsi/iscsi_target.c| 5 - include/target/iscsi/iscsi_transport.h | 2 ++ 2 files changed, 6