Re: [PATCH v2 08/20] lpfc: Fix duplicate NVME rport entries and namespaces.

2017-08-07 Thread Johannes Thumshirn
On Fri, Aug 04, 2017 at 05:47:19PM -0700, James Smart wrote: > + /* For nvme, swap the nrport. */ > + keep_nrport = new_ndlp->nrport; > + new_ndlp->nrport = ndlp->nrport; > + The above comment did trigger a "Please use the swap() macro" warning in my brain, which isn't applicable here.

[PATCH v2 08/20] lpfc: Fix duplicate NVME rport entries and namespaces.

2017-08-04 Thread James Smart
From: Dick Kennedy After lip, the driver sometimes would have two rports for the same device, allowing the namespaces to be duplicated by nvme. In lpfc_plogi_confirm_nport() the driver was not swapping the nrport maintained by the ndlp's undergoing address swapping. This allowed the 2nd rport to