[PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-05 Thread Sagi Grimberg
iSCSI needs to be at least aware that a task involves protection information. In case it does, after the transaction completed libiscsi will ask the transport to check the protection status of the transaction. Unlike transport errors, DIF errors should not prevent successful completion of the tran

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-17 Thread Or Gerlitz
On Wed, Mar 5, 2014 at 7:43 PM, Sagi Grimberg wrote: > > iSCSI needs to be at least aware that a task involves protection > information. In case it does, after the transaction completed > libiscsi will ask the transport to check the protection status > of the transaction. > > Unlike transport erro

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-17 Thread Mike Christie
On 03/17/2014 02:25 AM, Or Gerlitz wrote: > On Wed, Mar 5, 2014 at 7:43 PM, Sagi Grimberg wrote: >> > >> > iSCSI needs to be at least aware that a task involves protection >> > information. In case it does, after the transaction completed >> > libiscsi will ask the transport to check the protectio

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-17 Thread Sagi Grimberg
On 3/17/2014 6:59 PM, Mike Christie wrote: This patch is ok, but happened to the patch for the xmit task path? Hey Mike, Thanks for your Ack on this. The xmit_task fix was posted as a separate patch since it is not specific to this set (relevant also for existing data dma_mapping in xmit_t

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-17 Thread Or Gerlitz
On Mon, Mar 17, 2014, Sagi Grimberg wrote: > On 3/17/2014 6:59 PM, Mike Christie wrote: >> This patch is ok, but happened to the patch for the xmit task path? > Hey Mike, Thanks for your Ack on this. > The xmit_task fix was posted as a separate patch since it is not specific > to this set (relev