Re: [PATCH v2 2/6] scsi_io_completion rename variables

2018-03-26 Thread Bart Van Assche
On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > - blk_status_t error = BLK_STS_OK; > + blk_status_t blk_stat = BLK_STS_OK; /* u8: BLK_STS_OK is only 0 */ Hello Doug, This newly added comment looks really confusing to me. Can it be left out? Thanks, Bart.

[PATCH v2 2/6] scsi_io_completion rename variables

2018-03-18 Thread Douglas Gilbert
Change some variable names and associated comments for clarity. Correct some misleading comments. Signed-off-by: Douglas Gilbert Reviewed-by: Johannes Thumshirn --- drivers/scsi/scsi_lib.c | 57 ++--- 1 file changed, 30 insertions(+), 27 deletions(-)