Re: [PATCH v2 4/6] scsi_io_completion_action helper added

2018-03-27 Thread Bart Van Assche
On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > Place scsi_io_completion()'s complex error processing associated with a > local enumeration into a static helper function. That enumeration's > values start with "ACTION_" so use the suffix "_action" in the helper > function's name. Pleas

Re: [PATCH v2 4/6] scsi_io_completion_action helper added

2018-03-27 Thread Bart Van Assche
On Tue, 2018-03-27 at 09:36 -0400, Douglas Gilbert wrote: > On 2018-03-26 08:13 PM, Bart Van Assche wrote: > > On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > > > + /* sense not about current command is termed: deferred */ > > > > Do we really need comments that explain the SCSI specs?

Re: [PATCH v2 4/6] scsi_io_completion_action helper added

2018-03-27 Thread Douglas Gilbert
On 2018-03-26 08:13 PM, Bart Van Assche wrote: On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: + /* sense not about current command is termed: deferred */ Do we really need comments that explain the SCSI specs? If such a comment is added I think it should be added above the def

Re: [PATCH v2 4/6] scsi_io_completion_action helper added

2018-03-26 Thread Bart Van Assche
On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > + /* sense not about current command is termed: deferred */ Do we really need comments that explain the SCSI specs? If such a comment is added I think it should be added above the definition of scsi_sense_is_deferred() together with

[PATCH v2 4/6] scsi_io_completion_action helper added

2018-03-18 Thread Douglas Gilbert
Place scsi_io_completion()'s complex error processing associated with a local enumeration into a static helper function. That enumeration's values start with "ACTION_" so use the suffix "_action" in the helper function's name. Signed-off-by: Douglas Gilbert Reviewed-by: Johannes Thumshirn --- Re