Re: [PATCH v2 5/6] scsi_io_completion hints on fastpatch

2018-03-26 Thread Bart Van Assche
On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > - /* > - * Kill remainder if no retrys. > - */ > - if (blk_stat && scsi_noretry_cmd(cmd)) { > + /* Kill remainder if no retrys */ Since you are modifying this comment please also fix the spelling in that comment ("r

[PATCH v2 5/6] scsi_io_completion hints on fastpatch

2018-03-18 Thread Douglas Gilbert
Add likely() and unlikely() hints to conditionals on or near the fastpath. Signed-off-by: Douglas Gilbert Reviewed-by: Johannes Thumshirn --- A reviewer wanted any performance improvement (or otherwise) quantified. The improvement was so small, that ftrace ignored it. Inline timing code suggests