Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-08-11 Thread Alexander Gordeev
On Tue, Jul 29, 2014 at 07:24:03AM -0700, Christoph Hellwig wrote: > On Tue, Jul 29, 2014 at 04:15:45PM +0200, Alexander Gordeev wrote: > > Hmm.. 18/23 applies with a minor fuzz against > > git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17 > > Okay, it was just git-am being goofy t

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Christoph Hellwig
On Tue, Jul 29, 2014 at 04:15:45PM +0200, Alexander Gordeev wrote: > Hmm.. 18/23 applies with a minor fuzz against > git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17 Okay, it was just git-am being goofy then. I'll take care of it. -- To unsubscribe from this list: send the line

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Alexander Gordeev
On Tue, Jul 29, 2014 at 06:56:41AM -0700, Christoph Hellwig wrote: > On Tue, Jul 29, 2014 at 03:48:29PM +0200, Tomas Henzl wrote: > > I'm a bit confused - you were not commenting my text above I think? > > > > I see in drivers-for-3.17 this patch already applied 5607de7 > > but not yet the next on

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Christoph Hellwig
On Tue, Jul 29, 2014 at 03:48:29PM +0200, Tomas Henzl wrote: > I'm a bit confused - you were not commenting my text above I think? > > I see in drivers-for-3.17 this patch already applied 5607de7 > but not yet the next one (18/23) which also has a review, is there another > ack needed? Looks lik

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Tomas Henzl
On 07/29/2014 03:20 PM, Christoph Hellwig wrote: > On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote: >> Hi, >> patch looks good. >> >> A correction in pm8001_request_irq might be added too to allow >> the INT-X path when pm8001_setup_msix fails, but that is not part >> of this fix. >

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Christoph Hellwig
On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote: > Hi, > patch looks good. > > A correction in pm8001_request_irq might be added too to allow > the INT-X path when pm8001_setup_msix fails, but that is not part > of this fix. There's actually an equivalent fix already in through on

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Tomas Henzl
Hi, patch looks good. A correction in pm8001_request_irq might be added too to allow the INT-X path when pm8001_setup_msix fails, but that is not part of this fix. Tomas Reviewed-by: Tomas Henzl On 07/16/2014 08:05 PM, Alexander Gordeev wrote: > When a call to request_irq() failed pm8001_se

[PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-16 Thread Alexander Gordeev
When a call to request_irq() failed pm8001_setup_msix() still returns the success. This udate fixes the described misbehaviour. Signed-off-by: Alexander Gordeev Cc: xjtu...@gmail.com Cc: lindar_...@usish.com Cc: linux-scsi@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Jack Wang --- dr

[PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-04-14 Thread Alexander Gordeev
When a call to request_irq() failed pm8001_setup_msix() still returns the success. This udate fixes the described misbehaviour. Signed-off-by: Alexander Gordeev Cc: xjtu...@gmail.com Cc: lindar_...@usish.com Cc: linux-scsi@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Jack Wang --- dr