Re: [PATCH v3 03/15] scsi: ufs: verify command tag validity

2015-10-25 Thread ygardi
> 2015-09-02 19:13 GMT+09:00 Yaniv Gardi : >> A race condition appear to exist between request completion when >> scsi_done() is called to end the request and set the tag back to >> -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error >> handling which aborts

Re: [PATCH v3 03/15] scsi: ufs: verify command tag validity

2015-10-22 Thread subhashj
Looks good to me. Reviewed-by: Subhash Jadavani > A race condition appear to exist between request completion when > scsi_done() is called to end the request and set the tag back to > -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error > handling which

Re: [PATCH v3 03/15] scsi: ufs: verify command tag validity

2015-10-21 Thread Akinobu Mita
2015-09-02 19:13 GMT+09:00 Yaniv Gardi : > A race condition appear to exist between request completion when > scsi_done() is called to end the request and set the tag back to > -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error > handling which aborts the

[PATCH v3 03/15] scsi: ufs: verify command tag validity

2015-09-02 Thread Yaniv Gardi
A race condition appear to exist between request completion when scsi_done() is called to end the request and set the tag back to -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error handling which aborts the command and reuses it to request sense data. Sending the request sense is