Re: [PATCH v3 1/9] snic: snic module infrastructure

2015-04-08 Thread Narsimhulu Musini (nmusini)
Hi Christoph, Thank you for reviewing the patch. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 02/04/15 2:51 pm, "Christoph Hellwig" wrote: >> +/* >> + * Usage of the scsi_cmnd scratchpad. >> + * These fields are locked by the hashed

Re: [PATCH v3 1/9] snic: snic module infrastructure

2015-04-02 Thread Christoph Hellwig
> +/* > + * Usage of the scsi_cmnd scratchpad. > + * These fields are locked by the hashed req_lock. > + */ > +#define CMD_SP(Cmnd) ((Cmnd)->SCp.ptr) > +#define CMD_STATE(Cmnd) ((Cmnd)->SCp.phase) > +#define CMD_ABTS_STATUS(Cmnd)((Cmnd)->SCp.Message) > +#define CMD_LR_S

[PATCH v3 1/9] snic: snic module infrastructure

2015-04-02 Thread Narsimhulu Musini
snic_main.c contains module load and unload, global driver context, PCI Registration, PCI probe and remove, SCSI ML registration functionality. snic.h contains snic structure definition, snic global context, and prototypes. snic_os.h contains OS specific interfaces. snic_attrs.c contains device