Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-06 Thread Daniel Axtens
Hi, @@ -1857,9 +1884,18 @@ static int cxlflash_eh_device_reset_handler(struct scsi_cmnd *scp) get_unaligned_be32(((u32 *)scp-cmnd)[2]), get_unaligned_be32(((u32 *)scp-cmnd)[3])); - rcr = send_tmf(afu, scp, TMF_LUN_RESET); - if (unlikely(rcr)) -

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Brian King
On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h index ba070a5..3d6217a 100644 --- a/drivers/scsi/cxlflash/common.h +++ b/drivers/scsi/cxlflash/common.h @@ -76,6 +76,12 @@ enum cxlflash_init_state {

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Daniel Axtens
On Wed, 2015-08-05 at 17:30 -0500, Matthew R. Ochs wrote: Hi Brian, Thanks for reviewing. Comments inline below. -matt On Aug 5, 2015, at 11:04 AM, Brian King brk...@linux.vnet.ibm.com wrote: On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: diff --git

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Matthew R. Ochs
Hi Brian, Thanks for reviewing. Comments inline below. -matt On Aug 5, 2015, at 11:04 AM, Brian King brk...@linux.vnet.ibm.com wrote: On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h index ba070a5..3d6217a

[PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-02 Thread Matthew R. Ochs
Introduce support for enhanced I/O error handling. Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com --- drivers/scsi/cxlflash/Kconfig | 2 +- drivers/scsi/cxlflash/common.h | 11 ++- drivers/scsi/cxlflash/main.c | 151