Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items

2014-06-11 Thread Christoph Hellwig
Can I get a second review on this one from anyone? On Wed, Jun 04, 2014 at 01:34:56PM +0200, Paolo Bonzini wrote: Calling the workqueue interface on uninitialized work items isn't a good idea even if they're zeroed. It's not failing catastrophically only through happy accidents.

Re: Fwd: Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items

2014-06-11 Thread Stefan Hajnoczi
, venkate...@google.com Subject: Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items Message-ID: 20140611124731.ga16...@infradead.org In-Reply-To: 1401881699-1456-4-git-send-email-pbonz...@redhat.com Can I get a second review on this one from anyone? Reviewed-by: Stefan

Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items

2014-06-05 Thread Christoph Hellwig
On Wed, Jun 04, 2014 at 01:34:56PM +0200, Paolo Bonzini wrote: Calling the workqueue interface on uninitialized work items isn't a good idea even if they're zeroed. It's not failing catastrophically only through happy accidents. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Looks good,

[PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items

2014-06-04 Thread Paolo Bonzini
Calling the workqueue interface on uninitialized work items isn't a good idea even if they're zeroed. It's not failing catastrophically only through happy accidents. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- drivers/scsi/virtio_scsi.c | 4 +++- 1 file changed, 3 insertions(+), 1