...@neuling.org; imun...@au1.ibm.com; Manoj N. Kumar
Subject: [PATCH v4] cxlflash: Base support for IBM CXL Flash Adapter
SCSI device driver to support filesystem access on the IBM CXL Flash adapter.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/Kconfig|1
On 06/08/2015 04:41 PM, Manoj Kumar wrote:
> On 6/8/2015 12:54 PM, Brian King wrote:
>
>>> +
>>> +rcr = send_tmf(afu, scp, TMF_LUN_RESET);
>>> +if (unlikely(rcr))
>>> +rc = FAILED;
>>
>> Do you need to wait for all commands to the LUN to be returned before
>> returning from
>> her
On 6/8/2015 12:54 PM, Brian King wrote:
+
+ rcr = send_tmf(afu, scp, TMF_LUN_RESET);
+ if (unlikely(rcr))
+ rc = FAILED;
Do you need to wait for all commands to the LUN to be returned before returning
from
here? You could put a simple loop here, polling until there a
Brian:
Thank you for your review. Comments are inline.
- Manoj
On 6/8/2015 12:54 PM, Brian King wrote:
Looking pretty good. A few more comments.
Thanks,
Brian
+ spin_lock_irqsave(&cfg->tmf_waitq.lock, lock_flags);
+ if (cfg->tmf_active)
+ wait_event_interruptible_
On Jun 8, 2015, at 5:05 AM, Michael Neuling wrote:
>
> Reviewed-by: Michael Neuling
Thanks again for helping us to review the code.
>
> The core cxl changes needed for this are in mpe's powerpc next branch queued
> up
> for 4.2. They are in linux next-20150605. To compile this you'll need t
Looking pretty good. A few more comments.
Thanks,
Brian
On 06/05/2015 04:46 PM, Matthew R. Ochs wrote:
> +/**
> + * cxlflash_queuecommand() - sends a mid-layer request
> + * @host:SCSI host associated with device.
> + * @scp: SCSI command to send.
> + *
> + * Return:
> + * 0 on succes
On Fri, 2015-06-05 at 16:46 -0500, Matthew R. Ochs wrote:
> SCSI device driver to support filesystem access on the IBM CXL Flash adapter.
Few minor nits below but other than that it looks good to me. The CXL parts
are good and the rest of the driver is looking decent. FWIW:
Reviewed-by: Michael
SCSI device driver to support filesystem access on the IBM CXL Flash adapter.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/Kconfig|1 +
drivers/scsi/Makefile |1 +
drivers/scsi/cxlflash/Kconfig | 11 +
drivers/scsi/cxlflash/Make
8 matches
Mail list logo
