Re: [PATCH v4 1/7] target: use consistent left-aligned ASCII INQUIRY data

2018-11-30 Thread Lee Duncan
On 11/30/18 4:44 AM, David Disseldorp wrote: > On Wed, 28 Nov 2018 17:23:07 -0800, Lee Duncan wrote: > >>> +* unused bytes at the end of the field (i.e., highest offset) and the >>> +* unused bytes shall be filled with ASCII space characters (20h). >>> +*/ >>> + memset(&buf[8], 0x20,

Re: [PATCH v4 1/7] target: use consistent left-aligned ASCII INQUIRY data

2018-11-30 Thread David Disseldorp
On Wed, 28 Nov 2018 17:23:07 -0800, Lee Duncan wrote: > > +* unused bytes at the end of the field (i.e., highest offset) and the > > +* unused bytes shall be filled with ASCII space characters (20h). > > +*/ > > + memset(&buf[8], 0x20, 8 + 16 + 4); > > I dislike that you are using

Re: [PATCH v4 1/7] target: use consistent left-aligned ASCII INQUIRY data

2018-11-28 Thread Ly, Bryant
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote: > > spc5r17.pdf specifies: > 4.3.1 ASCII data field requirements > ASCII data fields shall contain only ASCII printable characters (i.e., > code values 20h to 7Eh) and may be terminated with one or more ASCII > null (00h) characters. >

Re: [PATCH v4 1/7] target: use consistent left-aligned ASCII INQUIRY data

2018-11-28 Thread Lee Duncan
On 11/28/18 5:01 PM, David Disseldorp wrote: > spc5r17.pdf specifies: > 4.3.1 ASCII data field requirements > ASCII data fields shall contain only ASCII printable characters (i.e., > code values 20h to 7Eh) and may be terminated with one or more ASCII > null (00h) characters. > ASCII data

[PATCH v4 1/7] target: use consistent left-aligned ASCII INQUIRY data

2018-11-28 Thread David Disseldorp
spc5r17.pdf specifies: 4.3.1 ASCII data field requirements ASCII data fields shall contain only ASCII printable characters (i.e., code values 20h to 7Eh) and may be terminated with one or more ASCII null (00h) characters. ASCII data fields described as being left-aligned shall have any