Re: [PATCH v4 29/32] cxlflash: Fix to double the delay each time

2015-09-29 Thread Daniel Axtens
"Matthew R. Ochs" writes: >> On Sep 28, 2015, at 8:40 PM, Daniel Axtens wrote: >> >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> "Matthew R. Ochs" writes: >> >>> From: Manoj Kumar >>> >>> The operator used to double the delay is incorrect and >>> does not result in delay doubl

Re: [PATCH v4 29/32] cxlflash: Fix to double the delay each time

2015-09-29 Thread Matthew R. Ochs
> On Sep 28, 2015, at 8:40 PM, Daniel Axtens wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > "Matthew R. Ochs" writes: > >> From: Manoj Kumar >> >> The operator used to double the delay is incorrect and >> does not result in delay doubling. >> >> To fix, use a left shift in

Re: [PATCH v4 29/32] cxlflash: Fix to double the delay each time

2015-09-28 Thread Daniel Axtens
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 "Matthew R. Ochs" writes: > From: Manoj Kumar > > The operator used to double the delay is incorrect and > does not result in delay doubling. > > To fix, use a left shift instead of the XOR operator. > I can see that the patch is correct, but this

Re: [PATCH v4 29/32] cxlflash: Fix to double the delay each time

2015-09-28 Thread Andrew Donnellan
On 26/09/15 09:19, Matthew R. Ochs wrote: From: Manoj Kumar The operator used to double the delay is incorrect and does not result in delay doubling. To fix, use a left shift instead of the XOR operator. Reported-by: Tomas Henzl Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar

[PATCH v4 29/32] cxlflash: Fix to double the delay each time

2015-09-25 Thread Matthew R. Ochs
From: Manoj Kumar The operator used to double the delay is incorrect and does not result in delay doubling. To fix, use a left shift instead of the XOR operator. Reported-by: Tomas Henzl Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King --- drivers/scsi/c