Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-20 Thread Dan Williams
On Mon, 2014-03-17 at 11:20 -0700, Dan Williams wrote: > On Sun, 2014-03-16 at 11:21 -0700, James Bottomley wrote: > > On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote: > > > On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley > > > > Hm, OK, if this is tied at the hip to async scanning, why do y

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-17 Thread Dan Williams
On Sun, 2014-03-16 at 11:21 -0700, James Bottomley wrote: > On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote: > > On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley > > wrote: > > > On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote: > > >> On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley >

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-16 Thread James Bottomley
On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote: > On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley > wrote: > > On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote: > >> On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley > >> wrote: > >> >> > In the long game, though this whole debate is

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-15 Thread Dan Williams
On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley wrote: > On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote: >> On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley >> wrote: >> >> > In the long game, though this whole debate is moot: setups with hard >> >> > wired start times adhere to them reg

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-15 Thread James Bottomley
On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote: > On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley > wrote: > >> > In the long game, though this whole debate is moot: setups with hard > >> > wired start times adhere to them regardless of what the system does, so > >> > they ignore start un

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-14 Thread Dan Williams
On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley wrote: >> > In the long game, though this whole debate is moot: setups with hard >> > wired start times adhere to them regardless of what the system does, so >> > they ignore start unit commands. Systems without hard wired start times >> > can usu

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread James Bottomley
On Mon, 2014-03-10 at 22:26 -0700, Dan Williams wrote: > On Mon, Mar 10, 2014 at 10:16 PM, James Bottomley > wrote: > > On Mon, 2014-03-10 at 21:47 -0700, Dan Williams wrote: > >> On Mon, Mar 10, 2014 at 9:19 PM, James Bottomley > >> wrote: > >> > On Mon, 2014-03-10 at 16:59 -0400, Alan Stern wro

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Dan Williams
On Mon, Mar 10, 2014 at 10:16 PM, James Bottomley wrote: > On Mon, 2014-03-10 at 21:47 -0700, Dan Williams wrote: >> On Mon, Mar 10, 2014 at 9:19 PM, James Bottomley >> wrote: >> > On Mon, 2014-03-10 at 16:59 -0400, Alan Stern wrote: >> >> On Mon, 10 Mar 2014, Dan Williams wrote: >> >> >> >> > >

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread James Bottomley
On Mon, 2014-03-10 at 21:47 -0700, Dan Williams wrote: > On Mon, Mar 10, 2014 at 9:19 PM, James Bottomley > wrote: > > On Mon, 2014-03-10 at 16:59 -0400, Alan Stern wrote: > >> On Mon, 10 Mar 2014, Dan Williams wrote: > >> > >> > > The only thing which is a bit concerning is that this doesn't have

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Dan Williams
On Mon, Mar 10, 2014 at 9:19 PM, James Bottomley wrote: > On Mon, 2014-03-10 at 16:59 -0400, Alan Stern wrote: >> On Mon, 10 Mar 2014, Dan Williams wrote: >> >> > > The only thing which is a bit concerning is that this doesn't have any >> > > throttling mechanism for simultaneous wakeups. Would t

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread James Bottomley
On Mon, 2014-03-10 at 16:59 -0400, Alan Stern wrote: > On Mon, 10 Mar 2014, Dan Williams wrote: > > > > The only thing which is a bit concerning is that this doesn't have any > > > throttling mechanism for simultaneous wakeups. Would this be able to > > > blow up the PSU if used on a machine with

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 03/10/2014 04:59 PM, Alan Stern wrote: > Why? The existing code doesn't have anything like that. The current sd code doesn't, but the libata code does use the AHCI staggered spinup feature flag as a hint to only spin up one drive at a time, so t

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Dan Williams
On Mon, Mar 10, 2014 at 1:59 PM, Alan Stern wrote: > On Mon, 10 Mar 2014, Dan Williams wrote: > >> > The only thing which is a bit concerning is that this doesn't have any >> > throttling mechanism for simultaneous wakeups. Would this be able to >> > blow up the PSU if used on a machine with a lo

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Alan Stern
On Mon, 10 Mar 2014, Dan Williams wrote: > > The only thing which is a bit concerning is that this doesn't have any > > throttling mechanism for simultaneous wakeups. Would this be able to > > blow up the PSU if used on a machine with a lot of spindles? > > Good point. The primary benefit is co

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Dan Williams
On Mon, Mar 10, 2014 at 1:43 PM, Tejun Heo wrote: > On Fri, Mar 07, 2014 at 06:52:06PM -0800, Dan Williams wrote: >> From: Dan Williams >> >> async_schedule() sd resume work to allow disks and other devices to >> resume in parallel. >> >> This moves the entirety of scsi_device resume to an async

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Tejun Heo
On Fri, Mar 07, 2014 at 06:52:06PM -0800, Dan Williams wrote: > From: Dan Williams > > async_schedule() sd resume work to allow disks and other devices to > resume in parallel. > > This moves the entirety of scsi_device resume to an async context to > ensure that scsi_device_resume() remains ord

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Alan Stern
On Fri, 7 Mar 2014, Dan Williams wrote: > On Fri, 2014-03-07 at 10:42 -0500, Alan Stern wrote: > > > #ifdef CONFIG_PM_SLEEP > > > > > > +#define do_pm_op(dev, op) \ > > > + dev->driver ? dev->driver->pm ? \ > > > + dev->driver->pm->op(dev) : 0 : 0 > > > > This will crash if dev->driver->pm->op

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-07 Thread Dan Williams
On Fri, 2014-03-07 at 10:42 -0500, Alan Stern wrote: > > #ifdef CONFIG_PM_SLEEP > > > > +#define do_pm_op(dev, op) \ > > + dev->driver ? dev->driver->pm ? \ > > + dev->driver->pm->op(dev) : 0 : 0 > > This will crash if dev->driver->pm->op is NULL. How about making it > easier to read, too

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-07 Thread Dan Williams
On Fri, Mar 7, 2014 at 7:42 AM, Alan Stern wrote: > On Wed, 5 Mar 2014, Dan Williams wrote: > >> async_schedule() sd resume work to allow disks and other devices to >> resume in parallel. >> >> This moves the entirety of scsi_device resume to an async context to >> ensure that scsi_device_resume()

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-07 Thread Alan Stern
On Wed, 5 Mar 2014, Dan Williams wrote: > async_schedule() sd resume work to allow disks and other devices to > resume in parallel. > > This moves the entirety of scsi_device resume to an async context to > ensure that scsi_device_resume() remains ordered with respect to the > completion of the s

[PATCH v5 3/3] scsi: async sd resume

2014-03-05 Thread Dan Williams
async_schedule() sd resume work to allow disks and other devices to resume in parallel. This moves the entirety of scsi_device resume to an async context to ensure that scsi_device_resume() remains ordered with respect to the completion of the start/stop command. For the duration of the resume, n