On 03/13/2017 11:48 AM, Hannes Reinecke wrote:
This is assuming that we're always running on a scsi_disk, and that
scsi_disk is the only one implementing 'eh_action'.
Neither of which is necessarily true.
Ah, OK. Thanks for explaining.
--
Mauricio Faria de Oliveira
IBM Linux Technology
On 03/13/2017 02:37 PM, Mauricio Faria de Oliveira wrote:
> Hannes,
>
> On 03/01/2017 06:15 AM, Hannes Reinecke wrote:
>> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
>> index f2cafae..cec439c 100644
>> --- a/drivers/scsi/scsi_error.c
>> +++ b/drivers/scsi/scsi_error.c
>> @@
Hannes,
On 03/01/2017 06:15 AM, Hannes Reinecke wrote:
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index f2cafae..cec439c 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -58,6 +58,7 @@
static int scsi_eh_try_stu(struct scsi_cmnd *scmd);
static
On 03/02/2017 09:16 PM, Benjamin Block wrote:
> Hej Hannes,
>
> On Wed, Mar 01, 2017 at 10:15:15AM +0100, Hannes Reinecke wrote:
>> The current medium access timeout counter will be increased for
>> each command, so if there are enough failed commands we'll hit
>> the medium access timeout for
Hej Hannes,
On Wed, Mar 01, 2017 at 10:15:15AM +0100, Hannes Reinecke wrote:
> The current medium access timeout counter will be increased for
> each command, so if there are enough failed commands we'll hit
> the medium access timeout for even a single failure.
> Fix this by making the timeout
On 03/02/2017 12:24 AM, Bart Van Assche wrote:
On Wed, 2017-03-01 at 10:15 +0100, Hannes Reinecke wrote:
The current medium access timeout counter will be increased for
each command, so if there are enough failed commands we'll hit
the medium access timeout for even a single failure.
This
On Wed, 2017-03-01 at 10:15 +0100, Hannes Reinecke wrote:
> The current medium access timeout counter will be increased for
> each command, so if there are enough failed commands we'll hit
> the medium access timeout for even a single failure.
This sentence describes multiple failed commands as a
Hannes, thanks for posting this.
I just found time to review the description so far:
Subject: [PATCHv3 1/6] scsi_error: count medium access timeout only once per EH
run
"... to prevent false positives"
Might be nice for understanding but also makes the short log quite long.
On
The current medium access timeout counter will be increased for
each command, so if there are enough failed commands we'll hit
the medium access timeout for even a single failure.
Fix this by making the timeout per EH run, ie the counter will
only be increased once per device and EH run.
Cc: Ewan
9 matches
Mail list logo
