Re: [PATCHv3 5/6] scsi: make scsi_eh_scmd_add() always succeed

2017-03-14 Thread Benjamin Block
Hello Hannes, On Wed, Mar 01, 2017 at 10:15:19AM +0100, Hannes Reinecke wrote: > scsi_eh_scmd_add() currently only will fail if no > error handler thread is started (which will never be the > case) or if the state machine encounters an illegal transition. > > But if we're encountering an invalid

Re: [PATCHv3 5/6] scsi: make scsi_eh_scmd_add() always succeed

2017-03-01 Thread Bart Van Assche
On Wed, 2017-03-01 at 10:15 +0100, Hannes Reinecke wrote: > scsi_eh_scmd_add() currently only will fail if no > error handler thread is started (which will never be the > case) or if the state machine encounters an illegal transition. > > But if we're encountering an invalid state transition >

[PATCHv3 5/6] scsi: make scsi_eh_scmd_add() always succeed

2017-03-01 Thread Hannes Reinecke
scsi_eh_scmd_add() currently only will fail if no error handler thread is started (which will never be the case) or if the state machine encounters an illegal transition. But if we're encountering an invalid state transition chances is we cannot fixup things with the error handler. So better add