Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-03-05 Thread Hannes Reinecke
On 03/02/2014 09:53 AM, Bart Van Assche wrote: On 02/13/14 11:27, Hannes Reinecke wrote: After discussion with jejb I've dropped the EVPD parsing. So with this version we're just displaying the EVPD page 0x80 and 0x83 as hexdumps; no parsing is attempted. This drastically simplifies the

Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-03-05 Thread Bart Van Assche
On 03/05/14 09:00, Hannes Reinecke wrote: On 03/02/2014 09:53 AM, Bart Van Assche wrote: A general comment about this patch series: I think the cached copies of these pages should be refreshed at least after an INQUIRY DATA HAS CHANGED unit attention code has been received. Some SCSI target

Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-03-05 Thread Hannes Reinecke
On 03/05/2014 09:23 AM, Bart Van Assche wrote: On 03/05/14 09:00, Hannes Reinecke wrote: On 03/02/2014 09:53 AM, Bart Van Assche wrote: A general comment about this patch series: I think the cached copies of these pages should be refreshed at least after an INQUIRY DATA HAS CHANGED unit

Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-03-02 Thread Bart Van Assche
On 02/13/14 11:27, Hannes Reinecke wrote: After discussion with jejb I've dropped the EVPD parsing. So with this version we're just displaying the EVPD page 0x80 and 0x83 as hexdumps; no parsing is attempted. This drastically simplifies the patch, and we don't have to worry about any parsing

Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-02-27 Thread Hannes Reinecke
On 02/13/2014 11:27 AM, Hannes Reinecke wrote: Hi all, After discussion with jejb I've dropped the EVPD parsing. So with this version we're just displaying the EVPD page 0x80 and 0x83 as hexdumps; no parsing is attempted. This drastically simplifies the patch, and we don't have to worry

[PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-02-13 Thread Hannes Reinecke
Hi all, After discussion with jejb I've dropped the EVPD parsing. So with this version we're just displaying the EVPD page 0x80 and 0x83 as hexdumps; no parsing is attempted. This drastically simplifies the patch, and we don't have to worry about any parsing errors in kernel space. Of course