Re: [Patch] plug async scan race at 1st node scan

2007-08-20 Thread Matthew Wilcox
On Mon, Aug 20, 2007 at 10:02:45AM -0400, James Smart wrote: > Well - depends on what the semantics of scan_start are to date, there > really are none and what does requiring it mean ? OK, and to make this discussion exceptionally useful, all comments are to be made in the context of modi

Re: [Patch] plug async scan race at 1st node scan

2007-08-20 Thread James Smart
Well - depends on what the semantics of scan_start are to date, there really are none and what does requiring it mean ? What's implied is that you want "bring up link" to be enabled in scan_start(). Doable, but the code paths weren't put together expecting this, so it may be a bit of wor

Re: [Patch] plug async scan race at 1st node scan

2007-08-20 Thread Matthew Wilcox
On Mon, Aug 20, 2007 at 09:10:35AM -0400, James Smart wrote: > In testing 2.6.23-rc3, there is a small window where the async-per-target > scan of the transport can beat the call from the LLDD to scsi_scan_host(). I'd assumed that events wouldn't come in until ->scan_start was called. I see lpfc d

[Patch] plug async scan race at 1st node scan

2007-08-20 Thread James Smart
In testing 2.6.23-rc3, there is a small window where the async-per-target scan of the transport can beat the call from the LLDD to scsi_scan_host(). If so, the target scan starts, and can add the sdev (and the sysfslinks) before the flags for async scan can prevent it. Thus, when async scan finishe