[RFC] libata-scsi: introducing SANITIZE translation

2016-07-07 Thread tom . ty89
From: Tom Yan With this patch, users can make use of the SANITIZE DEVICE feature set through utility like sg_sanitize. Support for BLOCK ERASE, CRYPTOGRAPHIC ERASE and EXIT FAILURE MODE has been implemented. Support for OVERWRITE that involves a parameter list has been left out for now. Further

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-07 Thread James Bottomley
On Fri, 2016-07-08 at 00:32 +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > With this patch, users can make use of the SANITIZE DEVICE feature > set through utility like sg_sanitize. > > Support for BLOCK ERASE, CRYPTOGRAPHIC ERASE and EXIT FAILURE MODE > has been implemented. Support for O

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-08 Thread Tom Yan
To be honest, that sounds like FUD to me. The exact reason why this can "safely" be introduced to the SATL is that, it is a "one-shot" command that would only be triggered by the user through a user space utility. It's nothing like TRIM that would be triggered by the filesystem layer or so "from t

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-08 Thread James Bottomley
On Sat, 2016-07-09 at 00:20 +0800, Tom Yan wrote: > To be honest, that sounds like FUD to me. If argument is to be in acronyms, it's KISS. > The exact reason why this can "safely" be introduced to the SATL is > that, it is a "one-shot" command that would only be triggered by the > user through a

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-08 Thread Tom Yan
On 8 July 2016 at 17:29, James Bottomley wrote: > > OK, since you ignore the argument about maintenance: safety for us > means that it doesn't bitrot as an almost never used addition. The > reason our SATL should only support the commands Linux uses is > precisely because if it's used often we ge

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-08 Thread James Bottomley
On Fri, 2016-07-08 at 19:38 +, Tom Yan wrote: > On 8 July 2016 at 17:29, James Bottomley > wrote: > > Or we could simply patch sg_sanitze to issue the ATA_16 pass > > through when it sees a sata device ... > > > > Ugh that sounds ugly to me. Anyway that's off-topic. Not really. The point

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-10 Thread Tom Yan
I don't suppose there would be any problem doing it in userspace / with ATA PASS-THROUGH anyway. I just couldn't agree that it would be the reason not to implement the translation (which covers the core part of the feature set) in the kernel. But certainly I wouldn't keep aruging on this. I don't

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-10-26 Thread Mark Lord
On 16-07-11 02:35 AM, Tom Yan wrote: I don't suppose there would be any problem doing it in userspace / with ATA PASS-THROUGH anyway. .. On 8 July 2016 at 17:29, James Bottomley wrote: .. Not really. The point is that you've proposed something as an addition to the kernel that can also be d