Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-04-10 Thread Bart Van Assche
On Tue, 2018-04-10 at 09:15 +0200, Jaco Kroon wrote: > I've not seen additional feedback on this (I may simply not be CCed). > > I've applied the patch to one of our hosts where we've had endless IO > lockups (with MQ enabled the host died within a day or two, sometimes > sub one hour, without it

Re: *** SPAM *** Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-04-10 Thread Jaco Kroon
Hi Martin, Bart, I've not seen additional feedback on this (I may simply not be CCed). I've applied the patch to one of our hosts where we've had endless IO lockups (with MQ enabled the host died within a day or two, sometimes sub one hour, without it typically ran for about two weeks).  With thi

Re: *** SPAM *** Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-04-05 Thread Jaco Kroon
Hi, Further to that, in the second last hunk there is a very clear functionality change: @@ -8756,12 +8859,12 @@ _scsih_mark_responding_expander(struct MPT3SAS_ADAPTER *ioc,     continue;     sas_expander->responding = 1; -   if (!encl_pg0_rc) +   

Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-03-28 Thread Martin K. Petersen
Bart, > Are you aware that if the 0-day test infrastructure suggests an improvement > for a patch that the patch that that improvement applies to gets ignored > unless either the patch is reposted with the improvement applied or that it > is explained why the suggested improvement is inappropriat

Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-03-27 Thread Bart Van Assche
On Wed, 2018-03-21 at 05:06 +0800, kbuild test robot wrote: > Fixes: 793a6223beef ("mpt3sas: Cache enclosure pages during enclosure add.") > Signed-off-by: Fengguang Wu > --- > mpt3sas_scsih.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sa

[RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-03-20 Thread kbuild test robot
Fixes: 793a6223beef ("mpt3sas: Cache enclosure pages during enclosure add.") Signed-off-by: Fengguang Wu --- mpt3sas_scsih.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index c93c5c5..67a43957