Re: [RFC v3 1/2] scsi: generate uevent for SCSI sense code

2017-07-13 Thread Johannes Thumshirn
On Wed, Jul 12, 2017 at 03:35:34PM -0700, Song Liu wrote: > + if (!test_bit(sshdr->sense_key & 0xf, > + >sense_event_filter)) While being technically correct, this looks a bit kludgy. Please pass in the whole sense_key without masking it. Byte, Johannes -- Johannes

[RFC v3 1/2] scsi: generate uevent for SCSI sense code

2017-07-12 Thread Song Liu
This patch adds capability for SCSI layer to generate uevent for SCSI sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT. We can configure which sense keys generate uevent for each device through sysfs entry sense_event_filter, which is a bitmap of "sense keys to generate uevent" For