Re: [ata_scsi_offline_dev] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:238

2017-11-06 Thread Hannes Reinecke
On 11/07/2017 12:12 AM, Linus Torvalds wrote: > On Mon, Nov 6, 2017 at 2:53 PM, Fengguang Wu wrote: >> >> The same dmesg happen to contain another libata related bug. Attached again. >> It's rare and in the error handling path, so unlikely a new regression. >> >> [ 49.608280] BUG: sleeping funct

Re: [ata_scsi_offline_dev] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:238

2017-11-06 Thread Martin K. Petersen
Linus, > But it does seem to be a new regression in 4.14, caused by commit > 8a97712e5314 ("scsi: make 'state' device attribute pollable"), because > that's what added the sysfs_notify() call to scsi_device_set_state(), > which made that spinlock be a problem. > > That commit came in through the

Re: [ata_scsi_offline_dev] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:238

2017-11-06 Thread Tejun Heo
Hello, On Mon, Nov 06, 2017 at 03:12:31PM -0800, Linus Torvalds wrote: > But it does seem to be a new regression in 4.14, caused by commit > 8a97712e5314 ("scsi: make 'state' device attribute pollable"), because > that's what added the sysfs_notify() call to scsi_device_set_state(), > which made t

Re: [ata_scsi_offline_dev] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:238

2017-11-06 Thread Linus Torvalds
On Mon, Nov 6, 2017 at 2:53 PM, Fengguang Wu wrote: > > The same dmesg happen to contain another libata related bug. Attached again. > It's rare and in the error handling path, so unlikely a new regression. > > [ 49.608280] BUG: sleeping function called from invalid context at > kernel/locking/