Re: [bug report] scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-14 Thread Dan Carpenter
On Fri, Jul 14, 2017 at 11:01:11AM +0200, Johannes Thumshirn wrote: > On Fri, Jul 14, 2017 at 10:46:03AM +0300, Dan Carpenter wrote: > >761 case SG_DXFER_FROM_DEV: > >762 if (hp->dxfer_len < 0) > > ^ > > Not possible. >

Re: [bug report] scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-14 Thread Johannes Thumshirn
On Fri, Jul 14, 2017 at 10:46:03AM +0300, Dan Carpenter wrote: >761 case SG_DXFER_FROM_DEV: >762 if (hp->dxfer_len < 0) > ^ > Not possible. Yup and thanks to: 647 else 648 hp->dxfer_direction =

[bug report] scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-14 Thread Dan Carpenter
Hello Johannes Thumshirn, The patch 68c59fcea1f2: "scsi: sg: fix SG_DXFER_FROM_DEV transfers" from Jul 7, 2017, leads to the following static checker warning: drivers/scsi/sg.c:762 sg_is_valid_dxfer() warn: unsigned 'hp->dxfer_len' is never less than zero. drivers/scsi/sg.c